Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make repeated 'using X ;' a no-op #374

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

grisumbras
Copy link
Contributor

This change allows putting using X ; into build scripts (as opposed to user configs) without creating a conflicting or wrong setup for module X. This is so that build scripts could rely on toolset modules having been configured (at least with default values).

The commit only updates toolset modules which allow using without arguments in the first place. It also does not change toolset modules for C++ compilers, as nobody does e.g. using gcc ; in their build scripts anyway.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

This change allows putting `using X ;` into build scripts (as opposed to
user configs) without creating a conflicting or wrong setup for module
X. This is so that build scripts could rely on toolset modules having
been configured (at least with default values).

The commit only updates toolset modules which allow `using` without
arguments in the first place. It also does not change toolset modules
for C++ compilers, as nobody does e.g. `using gcc ;` in their build
scripts anyway.
@grafikrobot grafikrobot merged commit fb743b7 into bfgroup:main Apr 23, 2024
142 checks passed
grafikrobot added a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants