Fix using relevant features in ac module #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule was misnamed, as it returned relevant properties, not features. The misnomer seems to had been the source of misuse: ac module did not consider any feature other than <link> to be relevant when checking for library existance. That could result in incorrect config checks. The change renames the rule to get-relevant-properties, and adds back get-relevant-features that returns features. In addition, it fixes the usage of get-relevant-features in ac module (it called the rule without arguments), and removes another usage where its invocation could not result in anything meaningful.
grafikrobot
force-pushed
the
fix/relevant-feats-in-ac
branch
from
a0d5ba2
to
d0d5c57
Compare
grafikrobot
added a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The rule
configure.get-relevant-featureswas misnamed, as it returned relevant properties, not features. The misnomer seems to had been the source of misuse:acmodule did not consider any feature other than<link>to be relevant when checking for library existance. That could result in incorrect config checks.The change renames the rule to
get-relevant-properties, and adds backget-relevant-featuresthat returns features. In addition, it fixes the usage ofget-relevant-featuresinacmodule (it called the rule without arguments), and removes another usage where its invocation could not result in anything meaningful.Types of changes