Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: adjusted for Intel oneAPI #417

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarDiehl
Copy link

works with 2024.2.1. PCH handling and Fortran compiler are not version dependent, probably breaks older systems

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

Further comments

Intel oneAPI contains new, LLVM-based compilers which have some incompatibilities to the older compilers. This makes b2 work with these new compilers.

Note: I believe that this change does not work on older systems, but to make it compatible I need help for writing jam files and, ideally, setting up a CI for Intel compiler

@hainest: This seems to be the place for the changes

works with 2024.2.1. PCH handling and Fortran compiler are not version
dependent, probably breaks older systems
@MarDiehl MarDiehl changed the title adjusted for Intel oneAPI draft: adjusted for Intel oneAPI Sep 21, 2024
@MarDiehl MarDiehl marked this pull request as draft September 21, 2024 07:25
@grafikrobot
Copy link
Member

setting up a CI for Intel compiler

Can you point me to set up instructions for the compiler? Preferably for older versions too. And I can try and add some CI.

@grafikrobot grafikrobot added the bug Something isn't working label Sep 21, 2024
@MarDiehl
Copy link
Author

setting up a CI for Intel compiler

Can you point me to set up instructions for the compiler? Preferably for older versions too. And I can try and add some CI.

There are Docker images on https://hub.docker.com/r/intel/oneapi. As far as I know, the Fortran compiler is only included in the HPC toolkit.
The images are huge, I remember some cases where GitHub actions failed due to lack of memory.

Regarding older versions: Intel offers downloads of older versions only to paying customers and I can't see older tags on DockerHub. I think there are two ways forward:

  1. build custom images and simply keep the old versions. I could imagine that hosting such images publicly violates Intels terms of usage.
  2. contact Intel and ask if they have some kind of free support for open source projects that allows to obtain older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants