Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches for setting up the UTF8-named directory for BOOST #421

Closed
wants to merge 2 commits into from

Conversation

tjcw
Copy link

@tjcw tjcw commented Nov 5, 2024

Proposed changes

I have troubles unpacking BOOST on AIX, because AIX does not support unicode file/directory names and there is a file in BOOST tests with a unicode name. This PR combines with a PR in the BOOST 'wave' repository so that the directory is unpacked with a regular name and renamed to its unicode name at bootstrap time. boostorg/wave#233 is the PR to look at.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):
    Usability improvement for BOOST on AIX

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
    I checked that the 'wave' tests still pass on my Linux workstation after making the change.
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@grafikrobot grafikrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new toolsets are almost identical to the existing vacpp+xlcpp, and to each other. It would make more sense to create a single toolset that can deal with the minor variations in each instead of two more.

Comment on lines +9 to +10
mkdir libs\wave\test\testwave\testfiles\utf8-test-ßµ™∃
copy libs\wave\test\testwave\testfiles\utf8-test\file.hpp libs\wave\test\testwave\testfiles\utf8-test-ßµ™∃\file.hpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These paths do not exists in the B2 sources. And hence fail when this script is run. These changes, if wanted, belong in the Boost bootstrap.

@@ -20,6 +20,9 @@ cd "$pwd"
cp "./src/engine/b2" . 2>/dev/null
cp "./src/engine/b2.exe" . 2>/dev/null

# Fix up the UTF8 test (AIX does not support utf8 file/dir names)
cp -r libs/wave/test/testwave/testfiles/utf8-test libs/wave/test/testwave/testfiles/utf8-test-ßµ™∃
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These paths do not exists in the B2 sources. And hence fail when this script is run. These changes, if wanted, belong in the Boost bootstrap.

@grafikrobot
Copy link
Member

I've converted this to a draft as it needs discussion and more work.

@tjcw
Copy link
Author

tjcw commented Nov 12, 2024

After re-checking, it looks like AIX does not need this patch. Closing.

@tjcw tjcw closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants