Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ng 17 support #325

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Ng 17 support #325

merged 7 commits into from
Dec 22, 2023

Conversation

tylerstarcher
Copy link
Contributor

@tylerstarcher tylerstarcher commented Dec 18, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Unit tests are passing ng test
  • Lint tests are passing ng lint

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR introduces support for Angular 17 as well as introduces standalone for the component and directive.

  • What is the current behavior? (You can also link to an open issue here)
    The current behavior only supports Angular 16. Not supported for Standalone Angular Components #323

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    This PR has breaking changes in that the DragScrollModule is no longer available.

  • Other information:

@tylerstarcher tylerstarcher marked this pull request as ready for review December 18, 2023 20:36
@tylerstarcher
Copy link
Contributor Author

This is my first contribution so please let me know if anything is out of order. #323 is resolved by this PR as well.

@tylerstarcher
Copy link
Contributor Author

@bfwg any chance you can take a look at this?

@bfwg
Copy link
Owner

bfwg commented Dec 20, 2023

The CI is failing with below error. Looks like we need to update https://github.com/bfwg/ngx-drag-scroll/blob/develop/.github/workflows/ci.yml#L19

Run npm run test ngx-drag-scroll -- --watch=false --browsers=ChromeHeadless

> [email protected] test
> ng test --watch=false ngx-drag-scroll --watch=false --browsers=ChromeHeadless

Node.js version v1[6](https://github.com/bfwg/ngx-drag-scroll/actions/runs/7253494775/job/19842404329?pr=325#step:6:7).20.2 detected.
The Angular CLI requires a minimum Node.js version of v1[8](https://github.com/bfwg/ngx-drag-scroll/actions/runs/7253494775/job/19842404329?pr=325#step:6:9).13.

Please update your Node.js version or visit https://nodejs.org/ for additional instructions.

Error: Process completed with exit code 3.

@tylerstarcher
Copy link
Contributor Author

Thanks! Updated to 18.x

bfwg
bfwg approved these changes Dec 22, 2023
View reviewed changes
Copy link
Owner

@bfwg bfwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bfwg bfwg merged commit 627f481 into bfwg:develop Dec 22, 2023
1 check passed
@bfwg
Copy link
Owner

bfwg commented Dec 22, 2023

17.0.1 is out with your changes. Great work.

@tylerstarcher tylerstarcher deleted the ng-17-support branch December 23, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfwg bfwg bfwg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerstarcher @bfwg