feat: angular v18 support #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bfwg it's my first commit. Can you have a look if anything is in order? |
|
Hi, looks like ci is failing. Can you try running 'npm ci' locally and make sure it passes? |
|
Hi, I couldn't reproduce it on my local osx environment. I figured out it's somehow related to nx. However i found multiple threads with a possible fix I implemented. E.g. here on stackoverflow or this issue. They recommend to add optional dependencies and install them on CI which seems to work. Here is the proof. |
|
@bfwg what do you think about it? |
|
18.0.0 is out on npm. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng testng lintWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR introduces support for Angular 18.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: