feat: lido gho #526
Closed
feat: lido gho #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 Build logsCompiling 364 files with Solc 0.8.20
Solc 0.8.20 finished in 176.95s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
--> lib/aave-helpers/src/swaps/AaveSwapper.sol:138:5:
|
138 | address erc20Token
| ^^^^^^^^^^^^^^^^^^
Warning (2018): Function state mutability can be restricted to pure
--> lib/aave-helpers/src/ProtocolV2TestBase.sol:663:3:
|
663 | function _logReserveConfig(ReserveConfig memory config) internal view {
| ^ (Relevant source part starts here and spans across multiple lines).
| Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|---------------------------------------------------------------------------------------------|------------------|-------------------|--------------------|---------------------|
| AaveGovernanceV2 | 44 | 94 | 24,532 | 49,058 |
| AaveSafetyModule | 44 | 94 | 24,532 | 49,058 |
| AaveSwapper | 5,447 | 5,883 | 19,129 | 43,269 |
| AaveV2Avalanche | 44 | 94 | 24,532 | 49,058 |
| AaveV2AvalancheAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV2Avalanche_ReserveFactorUpdatesMidOctober_20241004 | 988 | 1,017 | 23,588 | 48,135 |
| AaveV2Avalanche_UpdateLegacyGuardian_20241016 | 348 | 486 | 24,228 | 48,666 |
| AaveV2Ethereum | 44 | 94 | 24,532 | 49,058 |
| AaveV2EthereumAMM | 44 | 94 | 24,532 | 49,058 |
| AaveV2EthereumAMMAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV2EthereumAMM_UpdateLegacyGuardian_20241016 | 348 | 486 | 24,228 | 48,666 |
| AaveV2EthereumAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV2Ethereum_ReserveFactorUpdatesMidOctober_20241004 | 988 | 1,017 | 23,588 | 48,135 |
| AaveV2Ethereum_UpdateLegacyGuardian_20241016 | 348 | 486 | 24,228 | 48,666 |
| AaveV2Polygon | 44 | 94 | 24,532 | 49,058 |
| AaveV2PolygonAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV2Polygon_ReserveFactorUpdatesMidOctober_20241004 | 2,384 | 2,454 | 22,192 | 46,698 |
| AaveV2Polygon_UpdateLegacyGuardian_20241016 | 348 | 486 | 24,228 | 48,666 |
| AaveV3Arbitrum | 44 | 94 | 24,532 | 49,058 |
| AaveV3ArbitrumAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3ArbitrumEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3ArbitrumExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Arbitrum_GHOCCIP150Upgrade_20241021 | 817 | 846 | 23,759 | 48,306 |
| AaveV3Arbitrum_GHOStewardV2Upgrade_20241007 | 1,360 | 1,389 | 23,216 | 47,763 |
| AaveV3Arbitrum_ReserveFactorUpdatesMidOctober_20241004 | 3,227 | 3,297 | 21,349 | 45,855 |
| AaveV3Arbitrum_RiskStewardPhase2_20240805 | 307 | 336 | 24,269 | 48,816 |
| AaveV3Arbitrum_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Avalanche | 44 | 94 | 24,532 | 49,058 |
| AaveV3AvalancheAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3AvalancheEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3AvalancheExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Avalanche_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Avalanche_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3BNB | 44 | 94 | 24,532 | 49,058 |
| AaveV3BNBAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3BNBEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3BNBExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3BNB_OnboardWstETHToAaveV3OnBNBChain_20241030 | 5,561 | 5,632 | 19,015 | 43,520 |
| AaveV3BNB_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3BNB_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Base | 44 | 94 | 24,532 | 49,058 |
| AaveV3BaseAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3BaseEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3BaseExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Base_IncreaseCbBTCSupplyCaps_20241004 | 3,146 | 3,216 | 21,430 | 45,936 |
| AaveV3Base_ReserveFactorUpdatesMidOctober_20241004 | 3,223 | 3,293 | 21,353 | 45,859 |
| AaveV3Base_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Base_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Ethereum | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFi | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFiAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFiEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFiExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumEtherFi_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3EthereumExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLido | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLidoAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLidoEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLidoExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3EthereumLido_AutomatedAGRSActivation_20241108 | 3,046 | 3,075 | 21,530 | 46,077 |
| AaveV3EthereumLido_GHOListingOnLidoPool_20241119 | 4,092 | 4,278 | 20,484 | 44,874 |
| AaveV3EthereumLido_OnboardAndEnableSUSDeLiquidEModeOnAaveV3MainnetAndLidoInstances_20241108 | 5,657 | 5,728 | 18,919 | 43,424 |
| AaveV3EthereumLido_OnboardEzETHToLidoInstance_20241021 | 6,194 | 6,265 | 18,382 | 42,887 |
| AaveV3EthereumLido_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3EthereumLido_WstETHSlope1UoptimalUpdate_20241001 | 3,250 | 3,320 | 21,326 | 45,832 |
| AaveV3Ethereum_AaveBGDPhase4_20241025 | 1,407 | 1,436 | 23,169 | 47,716 |
| AaveV3Ethereum_AaveCertoraContinuousSecurityServices_20241014 | 1,567 | 1,596 | 23,009 | 47,556 |
| AaveV3Ethereum_ChaosLabsAaveRiskManagementServiceRenewal_20241012 | 1,255 | 1,284 | 23,321 | 47,868 |
| AaveV3Ethereum_EnableSUSDeUSDTLiquid_20241125 | 3,117 | 3,187 | 21,459 | 45,965 |
| AaveV3Ethereum_FixUSDSBorrowRateToMatchSkySavingsRate_20241022 | 3,238 | 3,308 | 21,338 | 45,844 |
| AaveV3Ethereum_GHOCCIP150Upgrade_20241021 | 817 | 846 | 23,759 | 48,306 |
| AaveV3Ethereum_GHOStewardV2Upgrade_20241007 | 2,895 | 2,924 | 21,681 | 46,228 |
| AaveV3Ethereum_IncreaseCbBTCSupplyCaps_20241004 | 3,150 | 3,220 | 21,426 | 45,932 |
| AaveV3Ethereum_IncreaseUSDSBorrowRateToMatchSkySavingsRate_20241016 | 3,239 | 3,309 | 21,337 | 45,843 |
| AaveV3Ethereum_OnboardAndEnableSUSDeLiquidEModeOnAaveV3MainnetAndLidoInstances_20241108 | 3,817 | 3,887 | 20,759 | 45,265 |
| AaveV3Ethereum_OnboardRsETHToAaveV3Ethereum_20241104 | 5,957 | 6,028 | 18,619 | 43,124 |
| AaveV3Ethereum_PYUSDReserveConfigurationUpdateIncentiveCampaign_20241031 | 3,988 | 4,059 | 20,588 | 45,093 |
| AaveV3Ethereum_RemoveFraxFromIsolationModeOnAaveV3Mainnet_20241105 | 3,226 | 3,296 | 21,350 | 45,856 |
| AaveV3Ethereum_RenewLlamaRiskAsRiskServiceProvider_20241013 | 1,068 | 1,097 | 23,508 | 48,055 |
| AaveV3Ethereum_RiskStewardPhase2_20240805 | 307 | 336 | 24,269 | 48,816 |
| AaveV3Ethereum_SafetyModuleStkAAVEReEnableRewards_20241106 | 910 | 939 | 23,666 | 48,213 |
| AaveV3Ethereum_StkGHOIncentivesQ4_20241029 | 1,458 | 1,487 | 23,118 | 47,665 |
| AaveV3Ethereum_UpdateLegacyGuardian_20241016 | 1,062 | 1,413 | 23,514 | 47,739 |
| AaveV3Ethereum_WstETHReserveBorrowRateUpdateMainInstance_20241024 | 3,227 | 3,297 | 21,349 | 45,855 |
| AaveV3Gnosis | 44 | 94 | 24,532 | 49,058 |
| AaveV3GnosisAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3GnosisEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3GnosisExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Gnosis_ReserveFactorUpdatesMidOctober_20241004 | 3,225 | 3,295 | 21,351 | 45,857 |
| AaveV3Gnosis_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Gnosis_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Metis | 44 | 94 | 24,532 | 49,058 |
| AaveV3MetisAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3MetisEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3MetisExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Metis_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Metis_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Optimism | 44 | 94 | 24,532 | 49,058 |
| AaveV3OptimismAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3OptimismEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3OptimismExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Optimism_ReserveFactorUpdatesMidOctober_20241004 | 3,227 | 3,297 | 21,349 | 45,855 |
| AaveV3Optimism_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Optimism_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Polygon | 44 | 94 | 24,532 | 49,058 |
| AaveV3PolygonAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3PolygonEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3PolygonExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Polygon_ReserveFactorUpdatesMidOctober_20241004 | 3,226 | 3,296 | 21,350 | 45,856 |
| AaveV3Polygon_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Polygon_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| AaveV3Scroll | 44 | 94 | 24,532 | 49,058 |
| AaveV3ScrollAssets | 44 | 94 | 24,532 | 49,058 |
| AaveV3ScrollEModes | 44 | 94 | 24,532 | 49,058 |
| AaveV3ScrollExternalLibraries | 44 | 94 | 24,532 | 49,058 |
| AaveV3Scroll_RiskStewardPhase2_20240805 | 178 | 206 | 24,398 | 48,946 |
| AaveV3Scroll_UpdateLegacyGuardian_20241016 | 1,062 | 1,393 | 23,514 | 47,759 |
| Address | 44 | 94 | 24,532 | 49,058 |
| CCIPUtils | 4,968 | 5,021 | 19,608 | 44,131 |
| ChainHelpers | 44 | 94 | 24,532 | 49,058 |
| ChainIds | 44 | 94 | 24,532 | 49,058 |
| Client | 109 | 160 | 24,467 | 48,992 |
| CollectorUtils | 44 | 94 | 24,532 | 49,058 |
| ConfiguratorInputTypes | 44 | 94 | 24,532 | 49,058 |
| Create2Utils | 121 | 172 | 24,455 | 48,980 |
| Create2UtilsZkSync | 104 | 155 | 24,472 | 48,997 |
| DataTypes | 44 | 94 | 24,532 | 49,058 |
| ERC1967Proxy | 122 | 967 | 24,454 | 48,185 |
| ERC1967Utils | 44 | 94 | 24,532 | 49,058 |
| EngineFlags | 44 | 94 | 24,532 | 49,058 |
| Errors | 4,652 | 4,705 | 19,924 | 44,447 |
| GHODirectMinter | 4,113 | 4,616 | 20,463 | 44,536 |
| GHODirectMinterDeploymentLib | 44 | 94 | 24,532 | 49,058 |
| GovV3Helpers | 2,517 | 2,570 | 22,059 | 46,582 |
| GovV3StorageHelpers | 44 | 94 | 24,532 | 49,058 |
| GovernanceGuardians | 292 | 345 | 24,284 | 48,807 |
| GovernanceV3Arbitrum | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Avalanche | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3BNB | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Base | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Ethereum | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Gnosis | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Metis | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Optimism | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Polygon | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3PolygonZkEvm | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3Scroll | 44 | 94 | 24,532 | 49,058 |
| GovernanceV3ZkSync | 44 | 94 | 24,532 | 49,058 |
| IpfsUtils | 44 | 94 | 24,532 | 49,058 |
| MiscArbitrum | 44 | 94 | 24,532 | 49,058 |
| MiscAvalanche | 44 | 94 | 24,532 | 49,058 |
| MiscBNB | 44 | 94 | 24,532 | 49,058 |
| MiscBase | 44 | 94 | 24,532 | 49,058 |
| MiscEthereum | 44 | 94 | 24,532 | 49,058 |
| MiscGnosis | 44 | 94 | 24,532 | 49,058 |
| MiscMetis | 44 | 94 | 24,532 | 49,058 |
| MiscOptimism | 44 | 94 | 24,532 | 49,058 |
| MiscPolygon | 44 | 94 | 24,532 | 49,058 |
| MiscScroll | 44 | 94 | 24,532 | 49,058 |
| Payloads | 44 | 94 | 24,532 | 49,058 |
| PayloadsControllerUtils | 44 | 94 | 24,532 | 49,058 |
| ProtocolGuardians | 292 | 345 | 24,284 | 48,807 |
| ProxyAdmin | 990 | 1,235 | 23,586 | 47,917 |
| ProxyHelpers | 44 | 94 | 24,532 | 49,058 |
| RateLimiter | 44 | 94 | 24,532 | 49,058 |
| RenewalV2BasePayload | 348 | 595 | 24,228 | 48,557 |
| RenewalV3BasePayload | 1,062 | 1,509 | 23,514 | 47,643 |
| ReserveConfiguration | 128 | 179 | 24,448 | 48,973 |
| RewardsDataTypes | 44 | 94 | 24,532 | 49,058 |
| SafeCast | 44 | 94 | 24,532 | 49,058 |
| SafeERC20 | 44 | 94 | 24,532 | 49,058 |
| StorageHelpers | 44 | 94 | 24,532 | 49,058 |
| StorageSlot | 44 | 94 | 24,532 | 49,058 |
| TestNetChainIds | 44 | 94 | 24,532 | 49,058 |
| TransparentUpgradeableProxy | 1,088 | 2,274 | 23,488 | 46,878 |
| WadRayMath | 44 | 94 | 24,532 | 49,058 |🔧 Build logs zksyncCompiling 110 files with zksolc and ZKsync solc 0.8.20
zksolc and ZKsync solc 0.8.20 finished in 72.48s
Compiler run successful!
| Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|------------------------------------------------|------------------|-------------------|--------------------|---------------------|
| AaveV2Ethereum | 224 | 224 | 450,775 | 450,775 |
| AaveV2EthereumAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3Arbitrum | 224 | 224 | 450,775 | 450,775 |
| AaveV3ArbitrumAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3ArbitrumEModes | 224 | 224 | 450,775 | 450,775 |
| AaveV3ArbitrumExternalLibraries | 224 | 224 | 450,775 | 450,775 |
| AaveV3Avalanche | 224 | 224 | 450,775 | 450,775 |
| AaveV3AvalancheAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3AvalancheEModes | 224 | 224 | 450,775 | 450,775 |
| AaveV3AvalancheExternalLibraries | 224 | 224 | 450,775 | 450,775 |
| AaveV3Base | 224 | 224 | 450,775 | 450,775 |
| AaveV3BaseAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3BaseEModes | 224 | 224 | 450,775 | 450,775 |
| AaveV3BaseExternalLibraries | 224 | 224 | 450,775 | 450,775 |
| AaveV3Ethereum | 224 | 224 | 450,775 | 450,775 |
| AaveV3EthereumAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3EthereumEModes | 224 | 224 | 450,775 | 450,775 |
| AaveV3EthereumExternalLibraries | 224 | 224 | 450,775 | 450,775 |
| AaveV3Gnosis | 224 | 224 | 450,775 | 450,775 |
| AaveV3GnosisAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3GnosisEModes | 224 | 224 | 450,775 | 450,775 |
| AaveV3GnosisExternalLibraries | 224 | 224 | 450,775 | 450,775 |
| AaveV3Optimism | 224 | 224 | 450,775 | 450,775 |
| AaveV3OptimismAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3OptimismEModes | 224 | 224 | 450,775 | 450,775 |
| AaveV3OptimismExternalLibraries | 224 | 224 | 450,775 | 450,775 |
| AaveV3Polygon | 224 | 224 | 450,775 | 450,775 |
| AaveV3PolygonAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3PolygonEModes | 224 | 224 | 450,775 | 450,775 |
| AaveV3PolygonExternalLibraries | 224 | 224 | 450,775 | 450,775 |
| AaveV3ZkSync | 224 | 224 | 450,775 | 450,775 |
| AaveV3ZkSyncAssets | 224 | 224 | 450,775 | 450,775 |
| AaveV3ZkSyncEModes | 224 | 224 | 450,775 | 450,775 |
| AaveV3ZkSyncExternalLibraries | 224 | 224 | 450,775 | 450,775 |
| AaveV3ZkSync_RiskStewardPhase2_20240805 | 1,248 | 1,248 | 449,751 | 449,751 |
| Address | 224 | 224 | 450,775 | 450,775 |
| ChainHelpers | 224 | 224 | 450,775 | 450,775 |
| ChainIds | 224 | 224 | 450,775 | 450,775 |
| ConfiguratorInputTypes | 224 | 224 | 450,775 | 450,775 |
| Create2Utils | 416 | 416 | 450,583 | 450,583 |
| Create2UtilsZkSync | 416 | 416 | 450,583 | 450,583 |
| DataTypes | 224 | 224 | 450,775 | 450,775 |
| Deploy_AaveV3ZkSync_RiskStewardPhase2_20240805 | 3,680 | 3,680 | 447,319 | 447,319 |
| Errors | 14,112 | 14,112 | 436,887 | 436,887 |
| GovV3Helpers | 11,616 | 11,616 | 439,383 | 439,383 |
| GovV3StorageHelpers | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Arbitrum | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Avalanche | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3BNB | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Base | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Ethereum | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Gnosis | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Metis | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Optimism | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Polygon | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3PolygonZkEvm | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3Scroll | 224 | 224 | 450,775 | 450,775 |
| GovernanceV3ZkSync | 224 | 224 | 450,775 | 450,775 |
| IpfsUtils | 224 | 224 | 450,775 | 450,775 |
| MiscEthereum | 224 | 224 | 450,775 | 450,775 |
| Payloads | 224 | 224 | 450,775 | 450,775 |
| PayloadsControllerUtils | 224 | 224 | 450,775 | 450,775 |
| ProxyHelpers | 224 | 224 | 450,775 | 450,775 |
| ReserveConfiguration | 480 | 480 | 450,519 | 450,519 |
| SafeERC20 | 224 | 224 | 450,775 | 450,775 |
| StorageHelpers | 224 | 224 | 450,775 | 450,775 |
| TestNetChainIds | 224 | 224 | 450,775 | 450,775 | |
🌈Test ResultsNo files changed, compilation skipped 2024-11-27T07:44:25.270165Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.1.12", "diff-snapshots", "./reports/AaveV3EthereumLido_GHOListingOnLidoPool_20241119_before.json", "./reports/AaveV3EthereumLido_GHOListingOnLidoPool_20241119_after.json", "-o", "./diffs/AaveV3EthereumLido_GHOListingOnLidoPool_20241119_before_AaveV3EthereumLido_GHOListingOnLidoPool_20241119_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/[email protected]\n"Ran 1 test for src/20241119_AaveV3EthereumLido_GHOListingOnLidoPool/AaveV3EthereumLido_GHOListingOnLidoPool_20241119.t.sol:AaveV3EthereumLido_GHOListingOnLidoPool_20241119_Test Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 18.12s (17.88s CPU time) Ran 1 test suite in 18.12s (18.12s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests) Ran 4 tests for src/20241119_AaveV3EthereumLido_GHOListingOnLidoPool/GHODirectMinter.t.sol:GHODirectMinter_Test [PASS] test_withdrawAndBurn(uint256,uint256) (runs: 256, μ: 272831, ~: 272851) Ran 1 test suite in 485.43ms (480.62ms CPU time): 4 tests passed, 0 failed, 0 skipped (4 total tests) |
sakulstra
force-pushed
the
feat/lido-gho
branch
from
49edabd to
d6e06c3
Compare
kyzia551
reviewed
Nov 25, 2024
|
|
||
| function transferExcessToTreasury() external { | ||
| (uint256 capacity, ) = GHO.getFacilitatorBucket(address(this)); | ||
| DataTypes.ReserveDataLegacy memory reserveData = POOL.getReserveData(address(GHO)); |
There was a problem hiding this comment.
aToken can be immutable as well, no point to query every time
There was a problem hiding this comment.
the reason i query it here is that otherwise i would need to deploy the minter on the proposal, which makes testing a bit madness (as i would need to somehow extract the added address).
If you insist i can do it, but to me feels cleaner this way and 10k gas saved on a rather rare operation probably is not so important. We can still do it in an upgrade.
...AaveV3EthereumLido_GHOListingOnLidoPool/AaveV3EthereumLido_GHOListingOnLidoPool_20241119.sol
Outdated
Show resolved
Hide resolved
|
For me this looks ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showcase the idea of using the executor as a facilitator and minting.