Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balancer Claim Mining Rewards #577

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

efecarranza
Copy link
Contributor

Changelog

Allow balancer address to claim mining rewards.

Note

Where in the tests there is no attempt to claim a reward mentioned in the forum, it's because the rewards have not been initialized yet.

Copy link
Contributor

@ianflexa ianflexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note
Where in the tests there is no attempt to claim a reward mentioned in the forum, it's because the rewards have not been initialized yet.

In this case I think we should add in both tests if the claimer is correctly set in the rewards controller:

    assertEq(IRewardsController(AaveV3Ethereum.DEFAULT_INCENTIVES_CONTROLLER).getClaimer(proposal.BALANCER_VAULT()), proposal.CLAIMER());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants