-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rustls #126
Conversation
Ah, actually on second thought the Lines 375 to 376 in 0554fff
I'll explore a few other options. |
Alright, I've switched the strategy around a bit and introduced two new feature flags: Would love feedback on this approach as opposed to the one written in the OP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just released oneio=0.13.1
that adds lib-native-tls
and lib-rustls
flags.
https://github.com/bgpkit/oneio/releases/tag/v0.13.1
This should make the dependencies cleaner.
Co-authored-by: Mingwei Zhang <[email protected]>
Co-authored-by: Mingwei Zhang <[email protected]>
Co-authored-by: Mingwei Zhang <[email protected]>
Looks great! Thanks @digizeph. |
This is the final pull request in a series to add support for using rustls as the underlying TLS library for bgpkit-parser's dependencies. The two other related pull requests were:
This pull request introduces a new feature flag known as
parser-rustls
that enables oneio'srustls
feature flag. I'm not sure this is the best option, and would love feedback on this approach. Alternatively, we can also explore adding two new feature flags:native-tls
andrustls
, similar to what was done in bgpkit/oneio#21, but that feels like more of a breaking change, and this is a far more popular crate and would require users to explicitly opt into both flags when they want to useparser
:features = ["parser", "native-tls"]
orfeatures = ["parser", "rustls"]
.Happy to make updates based on the preferred approach, and thank you for considering this PR!