improved RIS Live module #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable simpler subscribe message creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focusse on the RIS-live client and server message handling. The updates include the addition of new message types, refactoring of existing code to use structured types, and enhancements to the WebSocket client example.
Enhancements to WebSocket Client Example:
examples/real-time-ris-live-websocket.rs: Refactored to use the newRisSubscribestruct for subscribing to messages, replacing the previous JSON-based approach. [1] [2]New Client Message Definitions:
src/parser/rislive/messages/client/mod.rs: Introduced a new module for RIS-live client message definitions, including traits and implementations for various message types.src/parser/rislive/messages/client/ping.rs: Added a newPingmessage type with serialization and unit tests.src/parser/rislive/messages/client/request_rrc_list.rs: Added a newRequestRrcListmessage type with serialization and unit tests.src/parser/rislive/messages/client/ris_subscribe.rs: Added a newRisSubscribemessage type with comprehensive subscription options and methods for building messages.src/parser/rislive/messages/client/ris_unsubscribe.rs: Added a newRisUnsubscribemessage type that usesRisSubscribefor unsubscribing.Refactoring and Organization:
src/parser/rislive/messages/mod.rs: Refactored to separate client and server message definitions into distinct modules.src/parser/rislive/messages/server/mod.rs: Introduced a new module for RIS-live server message definitions, consolidating server-related message types.