linux_perf_event: exclude_idle only on x86_64

Commit 93f19d3 added `exclude_idle = 1` to `linux_perf_event`. However, as reported in scylladb/scylladb#19227 (comment), `exclude_idle` is not supported on ARM platforms. This change sets `exclude_idle` only on known-to-work architectures (presently, it's only x86_64), assuming it is initialized to 0 as all other unset bitfields in `perf_event_attr`. Fixes scylladb#2298 Signed-off-by: Benny Halevy <[email protected]>
bhalevy · Jul 1, 2024 · 041523e · 041523e
1 parent 9d4e8ff
commit 041523e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/tests/perf/linux_perf_event.cc b/tests/perf/linux_perf_event.cc
@@ -90,7 +90,11 @@ make_linux_perf_event(unsigned config, pid_t pid = 0, int cpu = -1, int group_fd
             .disabled = 1,
             .exclude_kernel = 1,
             .exclude_hv = 1,
+#if defined(__x86_64__)
+            // exclude_idle is not supported on all architectures (e.g. aarch64)
+            // so enable it selectively only on architectures that support it.
             .exclude_idle = 1,
+#endif
             }, pid, cpu, group_fd, flags);
 }