module independent #103
Open
module independent #103
+53,142
−5,261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update identity、node、params、upgrade test
…iritamod into sv/module-independent
dreamer-zq
reviewed
Jul 16, 2024
modules/upgrade/keeper/keeper.go
Outdated
Comment on lines
55
to
57
| func (k Keeper) UpgradeKeeper() *upgradekeeper.Keeper { | ||
| return k.uk | ||
| return k.Keeper | ||
| } |
dreamer-zq
reviewed
Jul 16, 2024
modules/upgrade/keeper/keeper.go
Outdated
Comment on lines
62
to
77
| func (k *Keeper) SetUpgradeHandler(name string, upgradeHandler upgradetypes.UpgradeHandler) { | ||
| k.uk.SetUpgradeHandler(name, upgradeHandler) | ||
| k.Keeper.SetUpgradeHandler(name, upgradeHandler) | ||
| } | ||
|
|
||
| // ReadUpgradeInfoFromDisk returns the name and height of the upgrade | ||
| // which is written to disk by the old binary when panic'ing | ||
| // if there's an error in reading the info, | ||
| // it assumes that the upgrade info is not available | ||
| func (k Keeper) ReadUpgradeInfoFromDisk() (upgradetypes.Plan, error) { | ||
| return k.uk.ReadUpgradeInfoFromDisk() | ||
| return k.Keeper.ReadUpgradeInfoFromDisk() | ||
| } | ||
|
|
||
| // IsSkipHeight checks if the given height is part of skipUpgradeHeights | ||
| func (k Keeper) IsSkipHeight(height int64) bool { | ||
| return k.uk.IsSkipHeight(height) | ||
| return k.Keeper.IsSkipHeight(height) | ||
| } |
dreamer-zq
reviewed
Jul 16, 2024
modules/upgrade/depinject.go
Outdated
Comment on lines
43
to
45
| authority := authtypes.NewModuleAddress(govtypes.ModuleName) | ||
| cosmosupgradekeeper := upgradekeeper.NewKeeper(skipUpgradeHeights, in.Key, in.Cdc, "/", nil, authority.String()) | ||
| keeper := keeper.NewKeeper( | ||
| cosmosupgradekeeper, | ||
| ) | ||
| //cosmosupgradekeeper := upgradekeeper.NewKeeper(skipUpgradeHeights, in.Key, in.Cdc, "/", nil, authority.String()) | ||
| keeper := keeper.NewKeeper(skipUpgradeHeights, in.Key, in.Cdc, "/", nil, authority.String()) |
There was a problem hiding this comment.
authority should support to be injected by user
cyilong
force-pushed
the
sv/module-independent
branch
from
e786a36
to
936a181
Compare
…iritamod into sv/module-independent # Conflicts: # modules/upgrade/depinject.go # modules/upgrade/keeper/keeper.go # modules/upgrade/test/keeper_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.