Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance keyboard event handling to include select element in focus check #508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-one-v
Copy link

Summary:
Modified the keyboard event handler to include the select element in the focus check condition, ensuring the correct handling of Tab key events when a select element is focused.

Details:
Added select to the list of elements (input, textarea, button) that prevent further handling of the Tab key event.
This change ensures that when a select element is focused, the Tab key event will not trigger the custom focus logic, maintaining the expected behavior for form navigation.

Testing:
Manually tested the change to ensure that the Tab key behaves correctly when a select element is focused.
Confirmed that the modification does not affect the existing functionality for input, textarea, and button elements.

@gingerchew
Copy link
Collaborator

Hey there @alex-one-v,

Thanks for bringing this to our attention, currently we're on a PR freeze #472 while we prepare for the next version. I'll leave this open for right now so that others can find the solution if they run into the same issue 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants