-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to CircleCI 2.0 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on bids-apps/example#27.
Taking components from the FreeSurfer BIDS App.
git tag cannot be queried for the purpose of generating a name for the container cache.
Primarily to fix version of numpy for nibabel dependency. Also updates MRtrix3 to version 3.0.1.
These are now included in the MRtrix3 installation.
Exceeded 10 minutes with no output in build 79.
- Use apt-get rather than apt throughout. - Use correct version of tzdata for Singularity. - Force ants version in Singularity.
Missing changes from 8fb0fa3.
CircleCI job 286 failed with "write /dev/stdout: no space left on device"
- Don't attempt to call "docker builder prune", since it appears to not be supported on the CircleCI version of Docker. - Don't make any attempt to load cache in the build job.
Testing to see whether this prevents a "permission denied" error when attempting to extract the downloaded test data.
Separate test data for "preproc" and "participant" uploaded to OSF. Will also try to run separate jobs for testing "preproc" and "participant" analysis levels.
- Fix N=1 intensity normalisation factor using undefined variable due to having been duplicated from another area of code. - Defer calculation of voxel volume from the SessionPaths class constructor to later in execution, so that the scratch directory will have already been constructed, and therefore the Image.Header constructor will write the corresponding temporary JSON to the scratch directory, avoiding a filesystem write access issue in some circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at moving to CircleCI 2.0. My first attempts a long time ago were unsuccessful, but thanks to bids-apps/example#27 I now have a working example to go off.
Even if the CI is configured correctly up-front, it likely won't work the first time because I need to generate new test data to conform to the expectations of version
0.5.0
. In the process of making that change I'll hopefully include a wider breadth of tests, including BIDS raw data for different acquisition designs, to satisfy #76.