Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASSET-37] feat: introduce "wrapped-coin" tag #42

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

luke-yoon
Copy link
Contributor

@luke-yoon luke-yoon commented Jul 31, 2024

Pull Request

Chainrunner-v2 작업중, 지원 하는 asset을 분류해야 되는 need가 발생.
분류 과정 중, asset이 wrapped coin인지 여부를 지정 해야함
위 과정을 위해 manual하게 특정 네트워크의 특정 코인을 wrapped-coin으로 표시해준다.

Description

Related issue: ASSET-37

Changes

Chainrunner에 wrapped-coin으로 지정된 asset의 tags에 "wrapped-coin"을 추가한다

Types of Changes (multiple options can be selected)

  • Create asset information
  • Update asset information
  • Delete asset information
  • Other {{Please add description here}}

Checklist

  • Did you pass the tests? (Did you execute pytest -l in your PC and get a green light?)
  • Did you run the pre-process?
  • Have you added and run tests to validate the changes?
  • Have you updated the documentation?
  • Have you updated the version in {PWD}/VERSION if you need?

@luke-yoon
Copy link
Contributor Author

@jormal
enums/tags/asset.json 파일에도 "wrapped-coin" 을 추가하고
wrapped-coin이 들어 있는 info.json 파일의 최상단 tags에도
"wrapped-coin"을 추가해줘야 하는지 궁금합니다.

@jormal
Copy link
Collaborator

jormal commented Aug 2, 2024

@luke-yoon 하지 않는 것이 맞다고 보여집니다. avalanche network에도 weth가 있는데, 이것도 함께 wrapped-coin으로 보기엔 무리가 있다고 판단됩니다.

@jormal jormal merged commit 209b80d into main Aug 22, 2024
1 check passed
@jormal jormal deleted the feature/ASSET-37 branch August 22, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants