Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package name and enforce python version in setup.py #232

Merged
merged 2 commits into from
May 5, 2024
Merged

Add package name and enforce python version in setup.py #232

merged 2 commits into from
May 5, 2024

Conversation

shehrozek-cerebras
Copy link
Contributor

No package name is specified in the setup.py file, which yields errors when trying to install the bigcode-eval package via pip. Please this issue for details: #231

@shehrozek-cerebras shehrozek-cerebras changed the title Adding package name and enforce python version in setup.py Add package name and enforce python version in setup.py May 3, 2024
@shehrozek-cerebras
Copy link
Contributor Author

CC: @loubnabnl for reviews. Thanks!

@loubnabnl
Copy link
Collaborator

Hi, the package isn't published on PyPI so pip install bigcode_eval won't work, but you can do pip install git+https://github.com/bigcode-project/bigcode-evaluation-harness.git

@shehrozek-cerebras
Copy link
Contributor Author

shehrozek-cerebras commented May 3, 2024 •
edited
Loading

Hi, the package isn't published on PyPI so pip install bigcode_eval won't work, but you can do pip install git+https://github.com/bigcode-project/bigcode-evaluation-harness.git

Yes, I have this line in my requirements.txt file, but the installation via pip install -r requirements.txt still fails due to the same error as listed in the issue description. It passes with the changes in this PR.

loubnabnl
loubnabnl reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@loubnabnl loubnabnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, let's add it then , thanks!

setup.py Outdated Show resolved Hide resolved
@shehrozek-cerebras
Copy link
Contributor Author

@loubnabnl I have included your suggestion.

@loubnabnl loubnabnl merged commit 84b96da into bigcode-project:main May 5, 2024
1 check passed
phuonglvh pushed a commit to phuonglvh/bigcode-evaluation-harness that referenced this pull request Nov 15, 2024
@loubnabnl
Merge pull request bigcode-project#232 from shehrozek-cerebras/make_b…
ddc4f5b 
…igcode_pip_installable

Add package name and enforce python version in `setup.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loubnabnl loubnabnl loubnabnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shehrozek-cerebras @loubnabnl