-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nosubmit runs with default cluster config #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, however could you revert all the black formatting please? it makes it impossible for us to review the code changes
This reverts commit 8bb4868.
Done - it took a few commits but I got there. I deleted the other PR - not sure it was appropriate in the first place but now it doesn't make sense. |
merge this into the main branch. thanks @RobertArbon ! |
This addresses the following issues #30 and #32 and possibly impacts #28.
there were two problems here:
nosubmit
was different between the GMX and non-GMX config parsers. This was a simple fix and addresses cli-abfe -nosubmit #32nosubmit
the cluster configuration dictionary was set toNone
which raised an error in theScheduler.generate_scheduler_file
method.To fix (2) I've taken a guess at what you've intended and what is sensible and made the smallest change I could. Now the
nosubmit
flag has no influence on the generation of a cluster configuration.So now
nosubmit
will generate cluster config files taking into account thenumber_of_parallel_ligand_jobs
andnogpu
flags.I've also made some edits to the
gitignore
file for the outputs from the examples