-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor madx_run_clm.py #27
base: master
Are you sure you want to change the base?
Conversation
Might be in the future, but at least during these sprints, let's keep it separate. |
We might also want to reconfigure the file structure? My thoughts would be something like:
|
Yea the structure is a mess right now. There's too many duplication (e.g., on the eval side, we actually don't need I am working on it right now. |
for now. @lintangsutawika What do you have in mind in the |
this makes sense to me, but I had problems downloading XNLI when there was a folder called "xnli" in the same path. Renaming to anything else ( |
@haileyschoelkopf Fixed by a8486d4 (using |
@yongzx I'm not sure. I think parameter-efficient finetuning should be included in lang-adapt/ |
Current changes: just some unused / commented out code from
madx_run_clm.py
. There is more, but I was not certain why certain parts are commented out.We'll need to refactor the script as well once we add new ft strategies.
I also wonder whether it would be helpful to turn language experiments into a single packaged script (train tokenizer + adapt model + possibly run eval?) So that it is easier to onboard and have the others run experiments.