Exclude form elements within disabled fieldsets (#2012)

* Exclude form elements within disabled fieldsets * add test for disabled fieldsets * cleanup
bigskysoftware · Nov 30, 2023 · 4dc97a4 · 4dc97a4
1 parent 40cd1a5
commit 4dc97a4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/htmx.js b/src/htmx.js
@@ -2430,7 +2430,7 @@ return (function () {
         }
 
         function shouldInclude(elt) {
-            if(elt.name === "" || elt.name == null || elt.disabled) {
+            if(elt.name === "" || elt.name == null || elt.disabled || closest(elt, "fieldset[disabled]")) {
                 return false;
             }
             // ignore "submitter" types (see jQuery src/serialize.js)

diff --git a/test/core/parameters.js b/test/core/parameters.js
@@ -239,5 +239,12 @@ describe("Core htmx Parameter Handling", function() {
         }
     });
 
+    it('Input within disabled fieldset is excluded', function () {
+        var input = make('<form><input name="foo" value="bar"/><fieldset disabled><input name="do" value="rey"/></fieldset></form>');
+        var vals = htmx._('getInputValues')(input, "get").values;
+        vals['foo'].should.equal('bar');
+        should.equal(vals["do"], undefined);
+    })
+
 });