Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix test pipeline timing issues #1818

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

Telroshan
Copy link
Collaborator

  • Most important change is calling mocha run on DOMContentLoaded instead of directly from the inline script (it could run mocha before htmx initialized itself, that caused the 84 errors scenario, probably the 24 errors one too)
  • Changed a few hardcoded setTimeouts to rely on event listeners instead
  • Increased the timeout to 4s (formerly 2) on the 4 tests making a request to hypermedia.systems ; those were causing random local errors where the (at least my) network connection would apparently not be enough to fetch the page in less than 2s

@Telroshan Telroshan added the devops Changes to the repository structure or project management label Sep 21, 2023
@Telroshan Telroshan added the ready for review Issues that are ready to be considered for merging label Sep 21, 2023
@Telroshan
Copy link
Collaborator Author

Ran the pipeline a few times, passed tests everytime

@1cg 1cg merged commit bb5413d into bigskysoftware:dev Sep 21, 2023
@Telroshan Telroshan deleted the fix-tests branch September 22, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Changes to the repository structure or project management ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants