Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server Side Event Interrupted while the page was loading error message #2005

Closed
wants to merge 6 commits into from
Closed

Fix Server Side Event Interrupted while the page was loading error message #2005

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a890da0
Fix sse interrupted while the page was loading error
gungun974 Nov 18, 2023
ac39333
Don't use arrow function for ES5
gungun974 Nov 18, 2023
3b63882
Move beforeunload handler to `closeSSESourceBeforePageUnload` and rem…
gungun974 Nov 19, 2023
d4eac82
Revert "Move beforeunload handler to `closeSSESourceBeforePageUnload`…
gungun974 Nov 19, 2023
7c07f55
Replace spaces with tabs
gungun974 Nov 19, 2023
a0680a1
Dont refetch sseEventSource and use created source directly
gungun974 Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ext/sse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,13 @@ This extension adds support for Server Sent Events to htmx. See /www/extensions
var source = htmx.createEventSource(sseURL);
internalData.sseEventSource = source;

// Don't forget to disconnect the EventSource on page unload
window.addEventListener("beforeunload", function () {
if (source != undefined) {
source.close();
}
});

// Create event handlers
source.onerror = function (err) {

Expand Down