Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude form elements within disabled fieldsets #2012

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Exclude form elements within disabled fieldsets #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8b2274
Exclude form elements within disabled fieldsets
flixcor Nov 19, 2023
1a02b5d
add test for disabled fieldsets
flixcor Nov 19, 2023
af5bdec
cleanup
flixcor Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/htmx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2411,7 +2411,7 @@ return (function () {
}

function shouldInclude(elt) {
if(elt.name === "" || elt.name == null || elt.disabled) {
if(elt.name === "" || elt.name == null || elt.disabled || closest(elt, "fieldset[disabled]")) {
return false;
}
// ignore "submitter" types (see jQuery src/serialize.js)
Expand Down
7 changes: 7 additions & 0 deletions test/core/parameters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,5 +239,12 @@ describe("Core htmx Parameter Handling", function() {
}
});

it('Input within disabled fieldset is excluded', function () {
var input = make('<form><input name="foo" value="bar"/><fieldset disabled><input name="do" value="rey"/></fieldset></form>');
var vals = htmx._('getInputValues')(input, "get").values;
vals['foo'].should.equal('bar');
should.equal(vals["do"], undefined);
})

});