-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs anchors #3047
Docs anchors #3047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a code change request, just a personal opinion ; I prefer the link anchors on the left as it makes for a predictable display where if you want to copy the link to a section of the docs, it's always at the same X position (whereas on the right, it depends on the title's text length)
Looking at how the website behaves with different resolutions, it seems that we could maybe simply add a media query that resets the negative left margin of the anchors, below ~700px of screen width ? So that it doesn't go out of the window and is still at a predictable horizontal position
(Btw, if you want to, feel free to make a separate PR with just the anchor link fix, that I could approve & merge right away while we leave the style change being discussed)
Personal opinion again, but I see value in the anchor being offset to the left ; it stands out more, which helps identifying titles better, while keeping titles' text aligned with text body below them. Very subjective I know, but it looks more readable to me to have the texts aligned when possible. 670px looks to me to be the very minimum acceptable size for such a display change, and even there, it doesn't look very ideal to me to target these anchors, that feel a bit too close to the window's edge. As for why that size in particular;
Just to emphasize that it's not some random size guessing, but simply the media queries & the styling that's already being applied to the website by other CSS rules, thus sounds perfectly fine to me to add another media query |
Sure why not, the link color makes it clear it's clickable and makes it stand out from the standard text, sounds good to me. |
can you change the link image to just a hash character? i'm all about old-school but that image is a bit much (i though I did that at one point...) |
Sure. I'm not terribly attached to the emoji. |
To make sure they don't get cut off by weird browsers. Also make the anchor link text the 'link' emoji which is more fun than the hashtag.
f6b49f4
to
80a9b79
Compare
Fix the 'Configuring Response Handling Examples' header link and move anchor links to the right of headers to make sure they don't get cut off on certain display sizes. Also use link emoji as anchor link text rather than hashtag.