Cancel events from form associated buttons. #3070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify event filter uses in hx-trigger
* Change hx-trigger event filter example to avoid ambiguity
input is both a tag and an event.
* Document the scope difference between standard selector and event filter
from:input listens to the page and click[event.target.matches('input')] listens to the element.
* Document that event filters as an alternative to CSS selectors require eval
* Move note about eval to standard event filters section.
* Simplify the referenced to standard event filters in the standard event modifiers section, and link to the standard event filters section instead.
* End quote in the correct place in standard event modifier doc.
* Correct language on how event filters from:body receive events.
* hx-trigger filter example catches click events specifically.
Add htmx4s to scala examples
Doc: Fix typo in URL to prevent broken link redirect
* Added htmx contact app using Blazor SSR * add back whitespace
…nges it to 2.0.3 as it should be (#2980) Fix "Download a copy" link to point to current 2.0.3
`evt` is not the correct variable name here - it should be `e`.
* add htmgo * move
Add links to two Julia projects by Lee Phillips.
1cg
requested changes
Dec 11, 2024
| var button = byId('b1') | ||
| htmx._('shouldCancel')({ type: 'click' }, button).should.equal(true) | ||
| }) | ||
|
|
There was a problem hiding this comment.
I think if you put an hx-get on the form this could be an end to end test, rather than needing to reach into the internals of htmx. Does that sound reasonable to you?
This fixes an issues in which `bodyContains()` would incorrectly return false for nested shadow roots.
…node (#2976) * Do not execute hx-trigger="load" on re-initialization of an existing node * simplify initNode firstInit logic
Co-authored-by: shartley <[email protected]>
…and hx-disabled-elt (#2902) * Initial suggestion (squashed) Support multiple extended selectors for hx-include Additional test for nested standard selector Add @MichaelWest22 hx-disabled-elt multiple selector test Add hx-trigger `from` test with multiple extended selectors Simplify Include #2915 fix Update htmx.js Split for readability Don't apply global to previous selectors Rewrite loop, restore global recursive call, minimize diff Use break for better readability Co-Authored-By: MichaelWest22 <[email protected]> * Keep global as a first-position-only keyword * Wrapped selector syntax * Replace substring check by individual chars check * Fix format --------- Co-authored-by: MichaelWest22 <[email protected]>
…htmx into cancel-form-buttons
|
I kept mucking up the commits, but I think the final, clean PR is here now: #3072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe what changes you made, and why you feel they are necessary. Make sure to include
code examples, where applicable.
HTMX wasn't cancelling vanilla form submission from buttons outside of a form.
Corresponding issue: #2919 can probably be closed with this?
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
Added a test in
test/core/internals.jsChecklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded