-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MKS GB boards. #2886
Conversation
After the rebase doesn't work, I'll debug it soon. |
@ciotto if you have issues with serial communication it could be possible you need to apply the changes made in #2840 for the new GD MCU. Eventually simply use the old implementation (that worked for you) and gradually apply all the not HW based PRs not yet merged in your repo (I don't know how you repo was aligned to this repo in the last months) |
No, shouldn't be related, I applied these changes after the rebase (doesn't built without these). I rebased and tested commit by commit and after some hours of work I found that the problem is on the "last" commit 😑 (156e04b). I suspect that can be related to the changes on |
See the bugfixes on GD TFT variants provided by #2885 just merged today (a missing ~ in |
LOL, I found the same issue 😑. Now I can do some more deep tests. |
Ok, seems to work fine on both the known versions. Ready for review. |
Opened a PR on your repo. Simply merge my PR and push the update here |
@btt please consider to merge the PR. It is OK. Eventually, I will provide a minor cleanup on one of my next PR (not urgent). Thanks |
Requirements
To test this fix you need a MKS board with GigaDevice MCU (used on Artillery Genius Pro and other Artillery 3D printers).
Description
As you can see here, the new versions of the MKS boards use GigaDevice MCUs.
We know that there are at least 2 versions of the board that use two different versions of the bootloader:
Benefits
Add support to new versions of the MKS board that use GigaDevice MCUs.
Related Issues