Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MKS GB boards. #2886

Merged
merged 24 commits into from
Feb 19, 2024
Merged

Conversation

ciotto
Copy link
Contributor

@ciotto ciotto commented Jan 21, 2024

Requirements

To test this fix you need a MKS board with GigaDevice MCU (used on Artillery Genius Pro and other Artillery 3D printers).

Description

As you can see here, the new versions of the MKS boards use GigaDevice MCUs.

We know that there are at least 2 versions of the board that use two different versions of the bootloader:

  • TFT Controller v1.2. with bootloader V3.0.4 (tested)

TFT Controller v1.2

TFT Controller v1.4

Benefits

Add support to new versions of the MKS board that use GigaDevice MCUs.

Related Issues

@digant73
Copy link
Contributor

Related issue is #2391 not #2885. You have to use the following line to mark #2391 as fixed by this PR so #2391 will be automatically closed once your PR is merged:

fixes #2391

@ciotto
Copy link
Contributor Author

ciotto commented Jan 22, 2024

After the rebase doesn't work, I'll debug it soon.

@digant73
Copy link
Contributor

digant73 commented Jan 23, 2024

@ciotto if you have issues with serial communication it could be possible you need to apply the changes made in #2840 for the new GD MCU. Eventually simply use the old implementation (that worked for you) and gradually apply all the not HW based PRs not yet merged in your repo (I don't know how you repo was aligned to this repo in the last months)

@ciotto
Copy link
Contributor Author

ciotto commented Jan 23, 2024

@ciotto if you have issues with serial communication it could be possible you need to apply the changes made in #2840 for the new GD MCU. Eventually simply use the old implementation (that worked for you) and gradually apply all the not HW based PRs not yet merged in your repo (I don't know how you repo was aligned to this repo in the last months)

No, shouldn't be related, I applied these changes after the rebase (doesn't built without these).

I rebased and tested commit by commit and after some hours of work I found that the problem is on the "last" commit 😑 (156e04b).

I suspect that can be related to the changes on os_timer.c because if I comment the OS_TimerInitMs call on HW_Init I can see the screen.

@digant73
Copy link
Contributor

digant73 commented Jan 23, 2024

See the bugfixes on GD TFT variants provided by #2885 just merged today (a missing ~ in os_timer.c for the GD variants only). Rebase on current BTT repo (with last merged PR)

@ciotto
Copy link
Contributor Author

ciotto commented Jan 23, 2024

LOL, I found the same issue 😑.

Now I can do some more deep tests.

@ciotto ciotto marked this pull request as ready for review January 23, 2024 15:29
@ciotto
Copy link
Contributor Author

ciotto commented Jan 23, 2024

Ok, seems to work fine on both the known versions.

Ready for review.

@digant73
Copy link
Contributor

Opened a PR on your repo. Simply merge my PR and push the update here

@digant73
Copy link
Contributor

digant73 commented Jan 26, 2024

@btt please consider to merge the PR. It is OK. Eventually, I will provide a minor cleanup on one of my next PR (not urgent). Thanks

@bigtreetech bigtreetech merged commit fcc619d into bigtreetech:master Feb 19, 2024
@digant73 digant73 mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] New Artillery not flashing LCD on GD32F305
3 participants