Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove versioneer; use release-please for versioning #35

Merged
merged 4 commits into from
Jan 29, 2024
Merged

ci: Remove versioneer; use release-please for versioning #35

merged 4 commits into from
Jan 29, 2024

Conversation

sellth
Copy link
Contributor

@sellth sellth commented Jan 26, 2024

closes #34

@sellth sellth requested a review from holtgrewe January 26, 2024 13:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7693977177

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 4243270561: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@bihealth bihealth deleted a comment from github-actions bot Jan 26, 2024
holtgrewe
holtgrewe reviewed Jan 26, 2024
View reviewed changes
sonar-project.properties Outdated Show resolved Hide resolved
holtgrewe
holtgrewe approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request. Lgtm otherwise

@sellth sellth merged commit 54b6c14 into main Jan 29, 2024
8 checks passed
@sellth sellth deleted the release_please_version branch January 29, 2024 09:39
@sellth sellth mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtgrewe holtgrewe holtgrewe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove versioneer
2 participants
@sellth @holtgrewe