-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add deadpool-arangodb #153
base: master
Are you sure you want to change the base?
Conversation
@bikeshedder do you maybe have an idea what my problem with |
That variant was added back by accident when merging the arangodb PR.
`arangos` depends on `serde` with the `derive` feature anyways so it is of no use making this optional.
When running the tests you had to add I just fixed that by making the I also rebased the code on Only two issues remain: https://github.com/bikeshedder/deadpool/actions/runs/1416599665 btw. I would recommend against switching implementations via a feature gates in |
Yeah, i also not exactly a fan of misusing feature gates like that, but CI fails
|
2f4d3ba
to
b1cf396
Compare
This adds
deadpool-arangodb
to the repository.I have marked the PR as
WIP
, because there is still a problem withuse serde_1::Deserialize;
being marked asunresolved import
intests/arangodb.rs
and i can't figure out why.I added
BuildError::Config
back todeadpool
, becausearangors
does not use a config struct and as such does not have a config error that i could use for the case the pool was configured wrongly. If you prefer, we can leaveBuildError::Config
out and i can try adding such a value upstream (in arangors).Another point is, i had to use the newest
arangors
rev from git, to avoid a build error in the release crate version, coming from thetyped-builder
dependency, which afaik published a breaking change without adhering to semver.Addresses #94