Fix incorrectly reporting LDAP errors when cannot find HTPASSWD file #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Sorry for this taking so long to get merged. I have some plans in the works, and think I can manage to set aside some more time for Hauk in the coming time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the authenticated method drops through from the HTPASSWD case to the LDAP case when no htpasswd file is found.
This was mentioned in 2020 in issue #142 but was subsequently closed when the reporter reinstalled their system and no longer could see the issue.
I have also added translations for the new error. These were done through google translate, so I cannot guarantee the quality. I have added these in a separate commit in case you wish to not include them.