0.4.0 Release #246
Merged
0.4.0 Release #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hktalent
pushed a commit
to hktalent/webssh2
that referenced
this pull request
Jun 3, 2022
* feat: upgrade to socket.io 4.1.1 billchurch#242 * chore: lint ./app/client/src/js/index.js billchurch#242 * chore: eslint disable global Blob warning billchurch#242 * chore: lint ./app/index.js billchurch#242 * chore: lint ./app/server/app.js billchurch#242 * chore: setup eslint and airbnb rules disable standard billchurch#242 * Delete package-lock-old.json * chore: lint ./app/index.js billchurch#242 * feat: implement alpine docker image from billchurch#213 * chore: lint ./app/server/app.js still TODO for stop function billchurch#242 * chore: lint ./app/server/util.js billchurch#242 * chore: lint ./app/server/app.js reorg socket and safe shutdown * chore: grammar / spelling * chore: fix some misplaced next returns in some Express routes billchurch#242 * chore: lint ./app/server/socket.js billchurch#242 * chore: bump version in ./app/package.json billchurch#242 * docs: update docs for 0.4.0 billchurch#242 * chore: update package-lock.json * chore: install Prettier code linter billchurch#242 * chore: linting for Prettier billchurch#242 * chore: lint ./app/client/src/js/index.js billchurch#242 * chore: client linting billchurch#242 * Update package-lock.json * chore: repackage wbssh2 bundle for testing billchurch#242 * chore: convert ./app/client/src/js/index.js to typescript billchurch#242 * chore: remove html rendering from node * Update tsconfig.json * Update tsconfig.json * Delete index.js * Update ChangeLog.md * chore: config for development container billchurch#242 * Update BUILDING.md * feat: pull in billchurch#234 staged for 0.4.0 billchurch#242 * docs: update changelog * update package.json * chore: split config from app/server/app.js billchurch#242 * chore: version bump * chore: consistency * feat: overridebasic fixes billchurch#243 included for billchurch#242 * chore: remove serverlog code * docs: update changelog
hktalent
pushed a commit
to hktalent/webssh2
that referenced
this pull request
Jun 3, 2022
* feat: upgrade to socket.io 4.1.1 billchurch#242 * chore: lint ./app/client/src/js/index.js billchurch#242 * chore: eslint disable global Blob warning billchurch#242 * chore: lint ./app/index.js billchurch#242 * chore: lint ./app/server/app.js billchurch#242 * chore: setup eslint and airbnb rules disable standard billchurch#242 * Delete package-lock-old.json * chore: lint ./app/index.js billchurch#242 * feat: implement alpine docker image from billchurch#213 * chore: lint ./app/server/app.js still TODO for stop function billchurch#242 * chore: lint ./app/server/util.js billchurch#242 * chore: lint ./app/server/app.js reorg socket and safe shutdown * chore: grammar / spelling * chore: fix some misplaced next returns in some Express routes billchurch#242 * chore: lint ./app/server/socket.js billchurch#242 * chore: bump version in ./app/package.json billchurch#242 * docs: update docs for 0.4.0 billchurch#242 * chore: update package-lock.json * chore: install Prettier code linter billchurch#242 * chore: linting for Prettier billchurch#242 * chore: lint ./app/client/src/js/index.js billchurch#242 * chore: client linting billchurch#242 * Update package-lock.json * chore: repackage wbssh2 bundle for testing billchurch#242 * chore: convert ./app/client/src/js/index.js to typescript billchurch#242 * chore: remove html rendering from node * Update tsconfig.json * Update tsconfig.json * Delete index.js * Update ChangeLog.md * chore: config for development container billchurch#242 * Update BUILDING.md * feat: pull in billchurch#234 staged for 0.4.0 billchurch#242 * docs: update changelog * update package.json * chore: split config from app/server/app.js billchurch#242 * chore: version bump * chore: consistency * feat: overridebasic fixes billchurch#243 included for billchurch#242 * chore: remove serverlog code * docs: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING
Changes
./app/client/src/js/index.tsis now built on TypeScript (npm run buildwill generate javascript for client and place intoapp/client/public/webssh2.bundle.jsas before)Added
Authorization: Basicheader and replace with credentials specified inconfig.jsonfixes user.name/user.password superseeded by basicAuth #243. New config.json optionuser.overridebasicCONTRIBUTING
In this release, we're trying our best to conform to the Airbnb Javascript Style Guide. I'm hoping this will make contributions easier and keep the code readable. I love shortcuts more than anyone but I've found when making changes to code I've not looked at in a while, it can take me a few momements to deconstruct what was being done due to readbility issues. While I don't agree with every decision in the style guide (semi-colons, yuk), it is a good base to keep the code consistent.
If you've not used it before, I recommend installing the vscode extensions for that and Prettier and getting familiar. The autocorrections are great (especially if you hate dealing with semi-colons...)
As of 0.4.0-testing-0, the client code is written in TypeScript. It's not that much different from JavaScript, and the introduction strong typing will ultimately help to produce better code. Eventually we want to move the whole project to TypeScript but that make take a bit more time. Take a moment to look at ./app/client/src/js/index.ts to see what TypeScript looks like.