-
Notifications
You must be signed in to change notification settings - Fork 28
likhith/Text field UI component #234
base: master
Are you sure you want to change the base?
likhith/Text field UI component #234
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, I see that you combine TextArea
and Input
within one wrapper component. I think we should split it if it has specific behaviour. For the props, do use a clearer name like success
should be using a more detailed name like either success_message
. Another good way is to structure it in another way instead of a flat props. Example
hint_text props:
hint_text: {
error: "",
success: "",
hint:""
}
@@ -0,0 +1,450 @@ | |||
import zxcvbn from 'zxcvbn'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should lazy load zxcvbn
library since this is a huge package. We only use Password Meter at a few places. So, I think it's better to lazy load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will incorporate this suggestion
There is a lot of removal from package-lock.json. Can you please check it again? |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Addresses 61199#
Type of change
Author Checklist:
Please check relevant items before requesting for review.