Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 'not yet supported' error when packing classes #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RealHandy
Copy link

@RealHandy RealHandy commented May 28, 2019

New class behaviors in recent javascript cause a 'type is not yet supported' error when packing instances of class objects that have a constructor that returns class ClassName instead of Object.

This fixes (or works around) it by getting a toString() of what the constructor is and seeing if it starts with 'class'.

afrokick added a commit to peers/js-binarypack that referenced this pull request Jul 9, 2019
afrokick added a commit to peers/js-binarypack that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant