-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rails 7.2 and 8.0 #770
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your wording even better, thanks!
Just in case GH notification miss - @tiegz FYI |
Is there a timeline for merge? |
Tracking the PR ref is working for me but would love to see this get merged. |
Looks good. Is there a plan for when merging is expected? |
@zhuravel Rails 8.0 is just around the corner. Are you able to loosen rails version restriction or maybe create separate PR for it? |
@morgoth Done. |
FYI: Code from this PR works fine for us on Rails 8.0.0.rc1 in production. |
@binarylogic @jaredbeck @tiegz Can any of you review this and make a release? |
@msuliq I wanted to kindly follow up on this PR to see if there's anything we can move it forward since the other maintainers may be busy with life events. |
@kimyu92 thanks for the follow up, I’d be happy to assist in any way I can to help move this PR forward since I have been using this gem with reference to this branch, but I’m not currently a maintainer of this gem and don't have permissions to approve and merge PR's, I’d be more than willing to take on that responsibility if the maintaining team sees value in it. Let me know how I can help |
@kimyu92 @msuliq sorry, I'm not longer a maintainer on this repo/gem. Currently I think the lineup is @binarylogic and @jaredbeck |
Hi everyone, this looks good to me. I will merge when the tests pass. |
@binarylogic The tests have passed. Ready for a release |
Fixes #771.
For those who need to use this fix before the PR is merged, you can add the gem to your Gemfile like this: