Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails 7.2 and 8.0 #770

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

zhuravel
Copy link

@zhuravel zhuravel commented Aug 10, 2024

Fixes #771.

For those who need to use this fix before the PR is merged, you can add the gem to your Gemfile like this:

gem "authlogic", github: "binarylogic/authlogic", ref: "refs/pull/770/head"

Copy link

@ansonhoyt ansonhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your wording even better, thanks!

@morgoth
Copy link
Contributor

morgoth commented Aug 16, 2024

Just in case GH notification miss - @tiegz FYI

@zhuravel zhuravel mentioned this pull request Aug 21, 2024
@kjanoudi
Copy link

Is there a timeline for merge?

@sstrudeau
Copy link

Tracking the PR ref is working for me but would love to see this get merged.

@mjansing
Copy link

Looks good. Is there a plan for when merging is expected?

@morgoth
Copy link
Contributor

morgoth commented Oct 22, 2024

@zhuravel Rails 8.0 is just around the corner. Are you able to loosen rails version restriction or maybe create separate PR for it?

@zhuravel zhuravel changed the title Support Rails 7.2 Support Rails 7.2 and 8.0 Oct 22, 2024
@zhuravel
Copy link
Author

@morgoth Done.

@morgoth
Copy link
Contributor

morgoth commented Oct 28, 2024

FYI: Code from this PR works fine for us on Rails 8.0.0.rc1 in production.

@kimyu92
Copy link

kimyu92 commented Nov 6, 2024

@binarylogic @jaredbeck @tiegz Can any of you review this and make a release?

@kimyu92
Copy link

kimyu92 commented Nov 15, 2024

@msuliq I wanted to kindly follow up on this PR to see if there's anything we can move it forward since the other maintainers may be busy with life events.

@msuliq
Copy link
Contributor

msuliq commented Nov 15, 2024

@kimyu92 thanks for the follow up, I’d be happy to assist in any way I can to help move this PR forward since I have been using this gem with reference to this branch, but I’m not currently a maintainer of this gem and don't have permissions to approve and merge PR's, I’d be more than willing to take on that responsibility if the maintaining team sees value in it. Let me know how I can help

@tiegz
Copy link
Contributor

tiegz commented Nov 15, 2024

@kimyu92 @msuliq sorry, I'm not longer a maintainer on this repo/gem. Currently I think the lineup is @binarylogic and @jaredbeck

@binarylogic
Copy link
Owner

Hi everyone, this looks good to me. I will merge when the tests pass.

@morgoth
Copy link
Contributor

morgoth commented Nov 18, 2024

@binarylogic The tests have passed. Ready for a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Rails 7.2.
10 participants