Updated Eluna and lualib dependancy #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows LuaJIT to be used and also adds additional lua library version options.
-Update CI checks to include cloning submodule -Bump checkout step to newer version
-CMake file adjustments to exclude other core method headers -Commented out what appears to be a custom core hook as in the current version of Eluna that hook ID is in use and the function doesn't exist in the method headers -Adjusted OnDummyEffect placement and return(its not a bool function its a void) -Added missing int/uint/double getters
|
Great job @Niam5 ! I will check it out ASAP. |
|
This PR doesn't have the newly added functions. I'll work on those and submit another once this one gets merged so it doesn't get messy. |
|
Also please review the method headers under the vmangos directly in eluna and clean them up. You can remove all code not specific to vmangos and submit to the eluna repo and I can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR provides an updated lualib dependency that will allow different lua version and also luaJIT to be used. Also removed the old static merged Eluna files and replaces it with a submodule to the main Eluna repository. Being a submodule allows you to update from the project if you so desire or if there is a change that breaks the implementation on this core you can do nothing and the submodule will stay at the last version it was updated to and go no further.
Proof
Issues
How2Test
Todo / Checklist