Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change placement of PLAYER_EVENT_ON_KILLED_BY_CREATURE core hook #16

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

Niam5
Copy link

@Niam5 Niam5 commented Nov 1, 2023

🍰 Pullrequest

Placement was missing some causes of death. Due to new placement added check to make sure that player is the unit hitting the hook not an NPC

Proof

-User reported issue

Issues

  • None

How2Test

User reported that prior to movement if you wrote a script like the following:

local function PlayerDeath(event, killer, killed)
SendWorldMessage("|r Hardcore - Player: " .. killed:GetName() .. "|r got killed by Creature: " .. killer:GetName() .. "|r - with Level:" .. killed:GetLevel() .."")
end

RegisterPlayerEvent(8, PlayerDeath)

and then died to ticking damage, example was given for NPC https://www.wowhead.com/wotlk/npc=3203/fizzle-darkstorm and spell casted by him https://www.wowhead.com/wotlk/spell=7290/soul-siphon and if death occurred due to this it would not fire the event. After movement and guard checks the hook now fires when death is from that damage.

Todo / Checklist

  • None

-Placement was missing some causes of death. Due to new placement added check to make sure that player is the unit hitting the hook not an NPC
@bing2008 bing2008 merged commit d3bab98 into bing2008:eluna-support Nov 2, 2023
3 checks passed
@Niam5 Niam5 deleted the eluna-fixes branch November 25, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants