Fix double exit bug in parallel pipelines #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
|
OS = |
|
OS = |
|
OS:ubuntu-20.04 |
The reason why it worked on Ubuntu 20.04 was that the EXIT handler was not called, while on Ubuntu 24.04 it correctly is. Signed-off-by: Bolun Thompson <[email protected]>
BolunThompson
force-pushed
the
double-exit-bug
branch
from
3a94bf6 to
07b09be
Compare
|
OS = |
|
OS:ubuntu-20.04 |
angelhof
approved these changes
Jan 5, 2025
Signed-off-by: Bolun Thompson <[email protected]>
|
OS = |
|
OS:ubuntu-20.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #736, #738. This wasn’t a problem on Ubuntu 20.04 because the EXIT handler wasn’t called (for no obvious reason), so it only exited once.