Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in compile_asts #740

Merged
merged 3 commits into from
Jan 5, 2025
Merged

Conversation

BolunThompson
Copy link
Contributor

No description provided.

Signed-off-by: Bolun Thompson <[email protected]>
Copy link

OS =
CPU =
Ram =
Hash = c51471d
Kernel=
||
|-|-|-|-|-|-|-|-|-|

Copy link

OS =
CPU =
Ram =
Hash = e1133b4
Kernel=
||
|-|-|-|-|-|-|-|-|-|

Copy link

OS:ubuntu-20.04
Sun Dec 29 02:47:37 UTC 2024
intro: 2/2 tests passed.
interface: 42/42 tests passed.
compiler: 54/54 tests passed.

Copy link

OS:ubuntu-20.04
Sun Dec 29 02:51:31 UTC 2024
intro: 2/2 tests passed.
interface: 42/42 tests passed.
compiler: 54/54 tests passed.

@angelhof
Copy link
Member

angelhof commented Jan 5, 2025

Hmm, did this manifest as a bug somewhere? It is clearly a bug, but I am wondering whether this code is every useful if it never triggered any test 🤔

Copy link

github-actions bot commented Jan 5, 2025

OS =
CPU =
Ram =
Hash = a87c0dc
Kernel=
||
|-|-|-|-|-|-|-|-|-|

Copy link

github-actions bot commented Jan 5, 2025

OS:ubuntu-20.04
Sun Jan 5 08:27:17 UTC 2025
intro: 2/2 tests passed.
interface: 42/42 tests passed.
compiler: 54/54 tests passed.

Copy link

github-actions bot commented Jan 5, 2025

OS =
CPU =
Ram =
Hash = cb15ae4
Kernel=
||
|-|-|-|-|-|-|-|-|-|

Copy link

github-actions bot commented Jan 5, 2025

OS:ubuntu-20.04
Sun Jan 5 08:27:51 UTC 2025
intro: 2/2 tests passed.
interface: 42/42 tests passed.
compiler: 54/54 tests passed.

@BolunThompson
Copy link
Contributor Author

BolunThompson commented Jan 5, 2025

It doesn’t, now that I look at it closer. It’s from an older version where compiled_asts returned the AST to prevent compilation (instead of raising an exception). I removed the code.

@angelhof angelhof merged commit 2b93857 into binpash:future Jan 5, 2025
7 checks passed
@angelhof
Copy link
Member

angelhof commented Jan 5, 2025

Very cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants