-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in compile_asts #740
Conversation
Signed-off-by: Bolun Thompson <[email protected]>
c51471d
to
e1133b4
Compare
OS = |
OS = |
OS:ubuntu-20.04 |
OS:ubuntu-20.04 |
Hmm, did this manifest as a bug somewhere? It is clearly a bug, but I am wondering whether this code is every useful if it never triggered any test 🤔 |
Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
a87c0dc
to
cb15ae4
Compare
OS = |
OS:ubuntu-20.04 |
OS = |
OS:ubuntu-20.04 |
It doesn’t, now that I look at it closer. It’s from an older version where compiled_asts returned the AST to prevent compilation (instead of raising an exception). I removed the code. |
Very cool, thanks! |
No description provided.