Added missing tif.get_type_name() on struct/enum change #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem in
hooks.local_types_changed
.libbs/libbs/decompilers/ida/hooks.py
Lines 169 to 184 in e25ae7e
When a struct or enum is modified,
compat.typedef_info
returns(False, None, None)
, soname
is set toNone
.Later, the type cache is updated using
name=None
(self.interface.cached_ord_to_type_names[ordinal] = (name, new_type_type)
), causing major errors later on in the same function:libbs/libbs/decompilers/ida/hooks.py
Lines 159 to 163 in e25ae7e