Add Unread Divider #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only real content changes are: 1. The companion object 2. Formatting the two constructors to be multiline instead of one looong line Otherwise it's copy and paste of the DetailViewHolder and the imports that it needs.
|
Wow. This is from June and I haven't commented or merged. My apologies. I haven't worked on the Android app in a while. When I do, I'll certainly look at this and/or merge it. Looks very neat. Thank you for your contribution!! |
|
No problem! I’m running my fork, so I already have the unread divider and am happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a divider after the unread messages. Just like in messaging apps.
The exact string ("You are all caught up!") is open for discussion. Maybe something more translation-friendly. E.g. Slack on iOS has "You're up-to-date 🎉" when you scroll up. Signal has "1 Unread Message".
Also, the string is hardcoded in XML right now because I don't know how your string/translation workflow works. I'll leave it to you to properly integrate it into the string setup.