Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify copy-to-clipboard in Utils #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thgoebel
Copy link

This was originally motivated by removing the duplicate Toast on Android 13:
https://developer.android.com/develop/ui/views/touch-and-input/copy-paste#duplicate-notifications

Notes:

  • For the time being, I have left the two instances of special copy handling in the SettingsActivity.
  • The string usage can also be centralised.
    • No need to translate the same string multiple times. Also having "URL copied to clipboard" does really not improve the UX over "Copied to clipboard".
    • Only the the English strings.xml is "clean". The other languages are just "rename the most translated generic one, delete the rest".
    • No idea how to import these changes to Weblate.
    • The 2 special strings for the SettingsActivity are kept.

Tested on Android 12 and Android 13.

@binwiederhier
Copy link
Owner

Neat, thank you. Sorry for not responding in a long time. I haven't worked on the Android app in a long time. I'll review when I do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants