feat: use Get to determine digest of an image

binxio · Jul 31, 2023 · 32f2fed · 32f2fed
1 parent 7e9123d
commit 32f2fed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/ref/ref.go b/ref/ref.go
@@ -183,16 +183,12 @@ func (r ContainerImageReference) ResolveDigest() (*ContainerImageReference, erro
 		return nil, err
 	}
 
-	img, err := remote.Image(ref, remote.WithAuthFromKeychain(authn.DefaultKeychain))
-	if err != nil {
-		return nil, err
-	}
-	digest, err := img.Digest()
+	descriptor, err := remote.Get(ref, remote.WithAuthFromKeychain(authn.DefaultKeychain))
 	if err != nil {
 		return nil, fmt.Errorf("failed to get Digest for %s, %s", r, err)
 	}
 
-	return &ContainerImageReference{Name: r.Name, Tag: r.Tag, Digest: digest.String()}, nil
+	return &ContainerImageReference{Name: r.Name, Tag: r.Tag, Digest: descriptor.Digest.String()}, nil
 }
 
 func (r *ContainerImageReference) SetTag(tag string) {

diff --git a/ref/resolve_test.go b/ref/resolve_test.go
@@ -19,14 +19,11 @@ func TestImageResolve(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	img, err := remote.Image(ref, remote.WithAuthFromKeychain(authn.DefaultKeychain))
-	if err != nil {
-		t.Fatal(err)
-	}
-	digest, err := img.Digest()
+	descriptor, err := remote.Get(ref, remote.WithAuthFromKeychain(authn.DefaultKeychain))
 	if err != nil {
 		t.Fatal(err)
 	}
+	digest := descriptor.Digest
 
 	if digest.String() != rr.Digest {
 		t.Fatalf("expected %s, got %s", digest, rr.Digest)