Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give title to sub-schemas of oneOf for sum types #88

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

maksbotan
Copy link
Collaborator

No description provided.

@maksbotan maksbotan merged commit 65968b9 into master Nov 20, 2023
8 checks passed
dhess added a commit to hackworthltd/primer that referenced this pull request Feb 6, 2024
The previous commit bumped the `openapi3` package to version `3.2.4`,
which contains this pull request:

biocad/openapi3#88

The title of that PR is simply, "Give title to sub-schemas of oneOf
for sum types", and that is what has happened here to our golden test
output. Unhelpfully, there's no justification for why this change was
made, but it looks harmless enough. (This will presumably require a
corresponding schema change on the client side, though.)

We also bump the PVP for `openapi3` to reflect the new minimum version
requirement.

Signed-off-by: Drew Hess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant