-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update csvtk to v0.31.1 #52304
update csvtk to v0.31.1 #52304
Conversation
It seems that @apcamargo has added it to conda-forge channel: https://anaconda.org/conda-forge/csvtk. |
I didn’t check if |
I think it's better staying here, as some packages depend on it (maybe old versions). |
Conda-forge does have a linter that notifies that something exists in bioconda already, but it is admittedly easy to overlook among several auto-generated comments. Because of strict channel priority, it's difficult to move recipes back to bioconda once they exist in conda-forge. I'm not sure what the process is for removing something from conda-forge. I suspect you'd have to request some manual intervention from their core team. If you'd like to remove the recipe from bioconda, open a PR deleting meta.yaml and any other files from the recipe folder. The older versions will remain in the bioconda channel and those versions should be able to be installable if specified by users. |
@aliciaaevans Thanks for your message. As @apcamargo said, csvtk is a more general-purpose tool, so I think conda-forge should be the right place. I'll submit a PR to remove it from bioconda.
It's great! |
Do you mean the directory should be kept?
|
Remove the whole folder with its contents. |
OK, thanks @martin-g |
Describe your pull request here
Changes
csvtk filter2/mutate2/mutate3
:csvtk csv2json
:Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.