-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup: PR 811: install an upper-bounded version of Jinja2 during documentation build #812
Fixup: PR 811: install an upper-bounded version of Jinja2 during documentation build #812
Conversation
Set objects are no longer allowed as an index argument for a DataFrame constructor. Fixes #810
…cy during sphinx documentation build Ref: pallets/jinja#1630 Ref: sphinx-doc/sphinx#10291
@jayaddison thanks looks like this fixed the broken build. Would you mind moving the version restriction from the config file to the setup.py file? There's already a minimum jinja version specified there so it wouldn't be crazy to restrict to a specific version range. The better long term solution will be to update to a newer Sphinx version, but that might be complicated 🤷♂️ . |
…dependency during sphinx documentation build" This reverts commit de26d4d.
Good idea, thanks @ElDeveloper - I hadn't noticed the Although.. while starting work on this, I've noticed that I'm thinking about whether we could selectively apply that upper-bound only for the documentation build. |
…dependency Follows-on-from commit de26d4d.
Could you run continuous integration once more, @ElDeveloper? (the approach taken in ae84d8e is maybe a little unusual, but valid I think - |
Thanks @jayaddison, this makes a lot of sense. Not sure how setup.py will react to a repeated requirement for Jinja. |
It seemed to behave correctly based on some local testing (installing both |
@jayaddison I think this is a fine solution. Thanks so much! |
Thanks - you're welcome! |
I'm hopeful that this will resolve the continuous integration failure in #811.
It looks like the
ImportError: cannot import name 'environmentfilter' from 'jinja2'
error seen in the build logs there is a symptom of using some less-recent versions ofsphinx
(as packaged with stable/LTS Ubuntu versions) with quite-recent versions ofJinja2
-- particularly v3.1.0 ofJinja2
and beyond.Until a recent-enough version of
sphinx
is available in theubuntu-latest
GitHub runner image, it should be possible to install an upper-bounded version ofJinja2
as a workaround.Ref: Jinja 2 imports have been deprecated sphinx-doc/sphinx#10291
Ref: 3.1.0 update breaks Sphinx 3.5 pallets/jinja#1630
(please note: this pull request is opened against the master branch instead of the #811 pull request branch so that it is eligible for continuous integration -- but it's intended to be merged into #811)