Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daklapack Bulk Order Validation #101

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Daklapack Bulk Order Validation #101

wants to merge 5 commits into from

Conversation

colts661
Copy link
Contributor

@colts661 colts661 commented Apr 24, 2024 •
edited
Loading

Fixed #100

Added validation to Daklapack order addresses before submitting to Daklapack:

  • Empty rows are disregarded
  • Rows with incomplete information are hold from private API call
    • Only insertion, address2 can be empty
    • These rows are reflected in the output
  • A private API call will not be made if there is no complete address in the file

Added tests in tests/test_route.py:

  • Adjusted the original test_post_submit_daklapack_order_success since it covers the optional fields condition
  • Added test_post_submit_daklapack_order_hold that will not make a private API call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blank Spreadsheet Rows on Daklapack Bulk Order
1 participant
@colts661