sample summary report expansion #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayobi
changed the title
cassidysymons
requested changes
Oct 28, 2024
Comment on lines
66
to
75
| <tr> | ||
| <td colspan=3 style="text-align:left;padding:4px"> | ||
| <input type="text" name="text_input" placeholder="Enter value here" id="text_input"> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td colspan=3 style="text-align:left;padding:4px"> | ||
| <input type="file" name="file" id="file"> | ||
| </td> | ||
| </tr> |
There was a problem hiding this comment.
Can you please clearly label the fields, e.g. Single Search for the text input and Upload List for the file input? Also, can you either prevent both from being submitted or indicate on the UI which takes precedence if both have values?
There was a problem hiding this comment.
@ayobi The code to prevent both from being submitted looks good, but can you please clearly label the fields? Thanks.
There was a problem hiding this comment.
Gotcha. I updated the vars to reflect the id upload_list and single_search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, to get a sample summary report, 2 of the 3 ways we do this is by searching for a single barcode or searching through a csv file of barcodes. With the expansion, we are also going to be able to search via Kit ID, Email, Outbound Tracking Number, and Inbound Tracking Number and also see these fields in the output of the report.