Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for THDMI Japan signups #252

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Changes for THDMI Japan signups #252

merged 1 commit into from
Nov 3, 2022

Conversation

cassidysymons
Copy link
Collaborator

The scope of this PR is to support THDMI Japan signups using the Interested Users form on the existing platform. The actual THDMI Japan campaign will be launched on the new version of the TMI platform, so these PRs explicitly exclude Japanese translations for the consent documents and surveys.

To prevent the edge case of an existing account changing their account to Japanese and/or someone with an existing Kit ID/Activation Code from creating an account and selecting Japanese, I've prevented it from displaying as a language option in the Account Details screen.

Added:

  • ja_JP locale
  • workaound to prevent a user from selecting Japanese as their account language since localized consents/surveys are not available
  • Japan-specific address entry panel to submit_interest.jinja2, including validation rules

Copy link
Member

@wasade wasade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions

@wasade wasade merged commit 170eb34 into master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants