Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #14

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Update README.md #14

wants to merge 32 commits into from

Conversation

dferhadian
Copy link

Here's my assignment for this week
Damien Ferhadian

@leej3
Copy link

leej3 commented Mar 19, 2020

Sounds good. You 2 distinct steps, the latter more open ended to allow you to do more if you have the time. Should work out nicely. Remember to follow the rubric as you put it together.

@dferhadian
Copy link
Author

Hi John,
You showed me some example for my test last thursday on Zoom and I can't find it anymore (I thought it would stay in the damien_demo repository you created but it isn;t there anymore, could you help me with this?

@leej3
Copy link

leej3 commented May 4, 2020

@dferhadian
Copy link
Author

That's where I went but I don't see anything
There are just the files without anything written in it (it says for each folder and file that the last contribution was done 2 months ago)

@leej3
Copy link

leej3 commented May 4, 2020

Weird, don't know why that wasn't pushed. Fixed now.

@dferhadian
Copy link
Author

Thank you so much John!

dferhadian and others added 7 commits May 7, 2020 18:36
__file__ is a variable for the file that python is currently executing
useful in this case because the current working can be different
depending on where you ran your tests from
@leej3
Copy link

leej3 commented May 8, 2020

nice job. some issues with paths during testing that it seems many others had. With this you should be passing tests. congrats

@dferhadian
Copy link
Author

Thank you john!

@emilyyaklich
Copy link

emilyyaklich commented May 9, 2020

Hi Damien,

Well done on the project. Pandas is a useful tool for working with datasets and you employ it well in your code. For your test, the pandas.testing.assert_frame_equal might be helpful to you. Overall, great work!

Cheers,

Emily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants