-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ramita Karra README edits #23
base: master
Are you sure you want to change the base?
Conversation
Just to summarize for the following TAs... this is looking good. I have encouraged adding packaging/tests sooner rather than later. |
Hello, do you need help with anything at this point? You can post questions here or bring questions to the class today. |
Cutting it close! Ideally all the of the files in BIOF309_RDK would have been in the base directory. That's more conventional package organization (and is what the circleci tests expect). I've tweaked the circleci file to look there instead though. You need to be careful about using paths in tests. They should either be a temporary directory created on the fly or be files that exist in a data directory in the repository (I think in the tests directory is a good place to put them). Well done. With the small fixes you are now passing the tests. |
That makes sense, thank you for the comments @leej3. And thanks to you, @suhwanplee, and Emily for a great class! |
Hi Ramita, Well done on the project. It is well documented and shows an understanding of Python. In the future, I would suggest adding more robust tests to your code in order to ensure that all of your code is debugged methodically. Overall, great work! Cheers, Emily |
No description provided.