Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramita Karra README edits #23

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Ramita Karra README edits #23

wants to merge 16 commits into from

Conversation

dewanr2
Copy link

@dewanr2 dewanr2 commented Feb 28, 2020

No description provided.

@leej3
Copy link

leej3 commented Apr 25, 2020

Just to summarize for the following TAs... this is looking good. I have encouraged adding packaging/tests sooner rather than later.
The general strategy of iterating in a notebook and migrating the code/functions sounds too be going well though.

@leesup
Copy link

leesup commented May 7, 2020

Hello, do you need help with anything at this point? You can post questions here or bring questions to the class today.

@leej3
Copy link

leej3 commented May 8, 2020

Cutting it close! Ideally all the of the files in BIOF309_RDK would have been in the base directory. That's more conventional package organization (and is what the circleci tests expect). I've tweaked the circleci file to look there instead though.

You need to be careful about using paths in tests. They should either be a temporary directory created on the fly or be files that exist in a data directory in the repository (I think in the tests directory is a good place to put them).

Well done. With the small fixes you are now passing the tests.

@dewanr2
Copy link
Author

dewanr2 commented May 8, 2020

That makes sense, thank you for the comments @leej3. And thanks to you, @suhwanplee, and Emily for a great class!

@emilyyaklich
Copy link

emilyyaklich commented May 9, 2020

Hi Ramita,

Well done on the project. It is well documented and shows an understanding of Python. In the future, I would suggest adding more robust tests to your code in order to ensure that all of your code is debugged methodically. Overall, great work!

Cheers,

Emily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants