Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show test run in the model info page #352

Merged
merged 21 commits into from
Sep 26, 2023
Merged

Show test run in the model info page #352

merged 21 commits into from
Sep 26, 2023

Conversation

Nanguage
Copy link
Contributor

@Nanguage Nanguage commented Sep 7, 2023

Preview:

model-interface-page-s

Current issues: 1. Slow loading speed of model interface plugin 2. Window size (mainly height) is not suitable 3. Long waiting time for model operation 4. User needs to manually input axes name

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for bioimage ready!

Name Link
🔨 Latest commit 08e8b16
🔍 Latest deploy log https://app.netlify.com/sites/bioimage/deploys/651340741bb0fa000848c59e
😎 Deploy Preview https://deploy-preview-352--bioimage.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cfusterbarcelo
Copy link
Collaborator

Meeting Updates (11/09/2023)

Notes

  • Currently, running a model on a 3D image takes 2 to 3 minutes, which is longer than desired. We need to explore ways to reduce this time in the future.
  • Display expected dimensions for input images to improve user understanding.
  • Create a list of possible user errors, such as incorrect image dimensions, and generate user-friendly error messages.

Action Items

  • Add a download button for input and output images.
  • Display expected input image dimensions and format for each model.
  • Embed the input image within the window instead of opening it in a new dialog.
  • Implement frontend validation to check if the uploaded image has correct dimensions before sending it to the server.
  • Change the default behavior to not run the model automatically; allow the user to click "Run" when ready.
  • Implement a pop-up error message when the uploaded image dimensions do not match the expected ones.
  • Include an animation during model testing to provide visual feedback and avoid a static appearance.

@oeway oeway changed the title Add "Try the model" feature in ResourceItemInfo Show test run in the model info page Sep 11, 2023
@oeway
Copy link
Collaborator

oeway commented Sep 21, 2023

@Nanguage The CI is failing right now because format issue, you can run npm run format to fix this before your commits.

@Nanguage
Copy link
Contributor Author

Nanguage commented Sep 24, 2023

Updates 2023.09.25

  • Display expected input image dimensions and format for each model.
  • Embed the input image within the window instead of opening it in a new dialog.
  • Implement frontend validation to check if the uploaded image has correct dimensions before sending it to the server.
  • Change the default behavior to not run the model automatically; allow the user to click "Run" when ready.
  • Implement a pop-up error message when the uploaded image dimensions do not match the expected ones.
  • Include an animation during model testing to provide visual feedback and avoid a static appearance.
  • Add minimal_ui mode to the run_button, hide the 'show source code' and 'EditButton' in the minimal_ui mode

@oeway @cfusterbarcelo

https://deploy-preview-352--bioimage.netlify.app/#/

@netlify
Copy link

netlify bot commented Sep 25, 2023

Wei Ouyang left a comment:

recording

Browser metadata
Path:      /#/?tags=affable-shark&id=10.5281%2Fzenodo.5764892
Browser:   Chrome 116.0.0.0 on Mac OS 10.15.7
Viewport:  1215 x 727 @2x
Language:  en
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@oeway
Copy link
Collaborator

oeway commented Sep 26, 2023

@Nanguage The CI is failing due to format, please update it so we can proceed with the merging.

@oeway oeway merged commit dc2f3e7 into bioimage-io:main Sep 26, 2023
3 of 5 checks passed
@oeway
Copy link
Collaborator

oeway commented Sep 27, 2023

@Nanguage I just update the itk-vtk-viewer so it's now support synchronized view:

from imjoy_rpc import api
import numpy as np

image1 = np.random.randint(0, 255, (30, 30, 20))
image2 = np.random.randint(0, 255, (30, 30, 20))

async def setup():
    viewer1 = await api.createWindow(src="https://oeway.github.io/itk-vtk-viewer")
    await viewer1.setImage(image1)
    viewer2 = await api.createWindow(src="https://oeway.github.io/itk-vtk-viewer")
    await viewer2.setImage(image2)

    await viewer1.sync(viewer2)
    await viewer2.sync(viewer1)
api.export({"setup": setup})

@Nanguage
Copy link
Contributor Author

@Nanguage I just update the itk-vtk-viewer so it's now support synchronized view:

from imjoy_rpc import api
import numpy as np

image1 = np.random.randint(0, 255, (30, 30, 20))
image2 = np.random.randint(0, 255, (30, 30, 20))

async def setup():
    viewer1 = await api.createWindow(src="https://oeway.github.io/itk-vtk-viewer")
    await viewer1.setImage(image1)
    viewer2 = await api.createWindow(src="https://oeway.github.io/itk-vtk-viewer")
    await viewer2.setImage(image2)

    await viewer1.sync(viewer2)
    await viewer2.sync(viewer1)
api.export({"setup": setup})

Perhaps we can provide a checkbox for users to choose whether to synchronize the input and output image viewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants