Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (Empanada) 2D Instance Mitochondrial Segmentation in EM Images - 2D MitoNet #696

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

bioimageiobot
Copy link
Collaborator

This is an automatic PR created by the @bioimageiobot regarding changes to the resource item 10.5281/zenodo.10391887.
The following version(s) will be added:

Please review the changes and make sure the new item or version(s) pass the following check list:

  • Passed the bioimage.io CI tests: static (and dynamic) validations
  • The meta information for the RDF item is complete
    • The tags are complete and describe the model
    • Naming is intuitive and descriptive, example: Multi-Organ Nucleus Segmentation (StarDist 2D)
    • Authors are provided
    • Documentation is complete
      • For models, include an overview, describe how the model is trained, what is the training data, how to use the model, how to validate the results and list the references. TODO: Model documentation template.
  • Approved by at least one of the bioimage.io admin team member.

Maintainers: @abhishek-bhardwaj-IN

Note: If you updated or re-uploaded another version for the current item on Zenodo, this PR won't be changed automatically. To proceed, you can do the following:

  1. Block this version, but keep looking for future versions: Edit the current resource.yaml and keep the top-level status field as accepted, but change the status under the current version to blocked.
  2. Accept this version and keep looking for future versions: Merge this PR for now.
  3. Keep proposed version(s) (and this resource in general if it is new) as pending: Close this PR without merging.

Then wait for the CI on the main branch to complete. It should detect the new version(s) and create another PR for the new version(s).

Previous PRs of this resource: none

@esgomezm
Copy link
Contributor

esgomezm commented Dec 18, 2023

@oeway @jmetz @FynnBe it's the same issue as here, any idea?

@FynnBe
Copy link
Member

FynnBe commented Dec 23, 2023

Awesome! all checks pass!

Only one minor request:
the output data range

  data_range:
  - 0.0
  - 65535.0
  data_type: int16

is not valid for data_type: int16, did you mean to specify uint16?
(If so, 42c0da5 patches that)

@bioimageiobot
Copy link
Collaborator Author

@esgomezm esgomezm merged commit dd5374f into main Mar 12, 2024
8 checks passed
@esgomezm esgomezm deleted the auto-update-10.5281/zenodo.10391887 branch March 12, 2024 18:57
@esgomezm
Copy link
Contributor

@abhishek-bhardwaj-IN I merged the PR so you should be able to see the model in the following 24h :)

@esgomezm
Copy link
Contributor

@FynnBe I merged this PR because it was passing all the CI tests and the PR was reopened + tests are not passing. Any idea?

@FynnBe
Copy link
Member

FynnBe commented Mar 25, 2024

It didn't reopen the same PR, #730 was opened to add version 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants